Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

%s inserts the "subject", not the entire commit message. The subject is considered to be the first line of the commit message (I forget if there is a character limit), so a newline would simply be considered the delimiter (and would not appear in the output).

Otherwise, you would be correct --- that would have rendered the check useless.



Ahh, you're right. I get a little paranoid when dealing with user-supplied strings, but usually that's a good thing :)


Absolutely; your critical thought and inquiry is a very positive thing.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: